Add Profile Override for Non-Git Sources #135433
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @onur-ozkan (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Thank you for your effort! I will be available for the review around this weekend. In the meantime please ensure the CI is green and there are no arbitrary commits (e.g., merge commit) in the PR. You may wanna check out the guideline for doing that. |
onur-ozkan
removed
the
S-waiting-on-review
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rustbot label -A-compiletest, -A-rustc-dev-guide, -A-testsuite |
tanvincible
changed the title
rustbot
removed
A-compiletest
|
@rustbot label -has-merge-commits |
onur-ozkan
reviewed
Jan 18, 2025
onur-ozkan
reviewed
Jan 18, 2025
tanvincible
force-pushed
the
patch-1
branch
2 times, most recently
from
f0692f4 to
46454a2
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
reviewed
Jan 19, 2025
|
This PR modifies If appropriate, please update |
|
Thank you! @bors r+ rollup |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 20, 2025
Add Profile Override for Non-Git Sources ## PR description - Fixes rust-lang#135358 This PR introduces the following updates to 1. `bootstrap.py`: - If the `profile` is `None` and the source is non-git, the `profile` is automatically overridden to `"dist"`. - Ensures that options like `download-ci-llvm` and `download-rustc` are not used with non-git sources. An exception is raised if these options are present in the configuration when the source is non-git. 2. `bootstrap_test.py` - Added unit tests to verify both the profile override mechanism and the assertion for restricted options. These tests ensure the correct behavior for non-git sources and the handling of `if-unchanged` options. r? `@onur-ozkan` `@rustbot` T-bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR introduces the following updates to
bootstrap.py:profileisNoneand the source is non-git, theprofileis automatically overridden to"dist".download-ci-llvmanddownload-rustcare not used with non-git sources. An exception is raised if these options are present in the configuration when the source is non-git.bootstrap_test.pyThese tests ensure the correct behavior for non-git sources and the handling of
if-unchangedoptions.r? @onur-ozkan
@rustbot T-bootstrap